Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging of integrations and packages #1111

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 7, 2022

📜 Description

💡 Motivation and Context

Screenshot 2022-11-07 at 16 01 35

💚 How did you test it?

Running and checking the event on sentry.io

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 329.77 ms 367.31 ms 37.54 ms
Size 5.94 MiB 6.95 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7758e8 300.12 ms 349.88 ms 49.76 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
ef2f368 350.06 ms 429.44 ms 79.38 ms
3e9fb0e 329.14 ms 359.16 ms 30.02 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
0ceb89c 304.57 ms 357.18 ms 52.61 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms

App size

Revision Plain With Sentry Diff
d7758e8 5.94 MiB 6.95 MiB 1.01 MiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
ef2f368 5.94 MiB 6.89 MiB 975.81 KiB
3e9fb0e 5.94 MiB 6.95 MiB 1.01 MiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
0ceb89c 5.94 MiB 6.95 MiB 1.01 MiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto enabled auto-merge (squash) November 8, 2022 10:44
@marandaneto marandaneto merged commit 5d39473 into main Nov 8, 2022
@marandaneto marandaneto deleted the fix/missing-integrations-packages branch November 8, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants