-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Flutter replay #2011
WIP: Flutter replay #2011
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Flutter replay ([#2011](https://github.com/getsentry/sentry-dart/pull/2011)) If none of the above apply, you can opt out of this check by adding |
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplay.kt
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplay.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/test/kotlin/io/sentry/flutter/SentryFlutterTest.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/test/kotlin/io/sentry/flutter/SentryFlutterTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|205 col 1| Unexpected indentation (10) (should be 6)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|355 col 1| Unexpected indentation (6) (should be 4)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|382 col 1| Unexpected indentation (8) (should be 6)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|382 col 9| Newline expected after opening parenthesis
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|383 col 1| Unexpected indentation (8) (should be 6)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|383 col 9| Parameter should start on a newline
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|384 col 1| Unexpected indentation (8) (should be 6)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|384 col 9| Parameter should start on a newline
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|412 col 1| Unexpected indentation (8) (should be 6)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|413 col 1| Unexpected indentation (12) (should be 8)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|414 col 1| Unexpected indentation (12) (should be 8)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|415 col 1| Unexpected indentation (12) (should be 8)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt|416 col 1| Unexpected indentation (8) (should be 6)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d53c6fa | 282.83 ms | 344.00 ms | 61.17 ms |
ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
48adddf | 353.96 ms | 431.10 ms | 77.14 ms |
b0811cc | 580.00 ms | 675.69 ms | 95.69 ms |
89ea268 | 320.35 ms | 377.68 ms | 57.33 ms |
ccc09e4 | 308.21 ms | 357.74 ms | 49.54 ms |
d089990 | 361.67 ms | 442.50 ms | 80.83 ms |
2331d89 | 352.45 ms | 417.34 ms | 64.89 ms |
1a93825 | 347.31 ms | 424.54 ms | 77.23 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d53c6fa | 6.16 MiB | 7.14 MiB | 1011.18 KiB |
ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
48adddf | 6.27 MiB | 7.20 MiB | 959.09 KiB |
b0811cc | 6.33 MiB | 7.27 MiB | 954.02 KiB |
89ea268 | 6.06 MiB | 7.03 MiB | 989.24 KiB |
ccc09e4 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
d089990 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
2331d89 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
1a93825 | 6.27 MiB | 7.20 MiB | 956.36 KiB |
I've used jni & jnigen here to integrate with native sentry-java replay support for Android. However, in order to make callbacks work, we need at least jni/jnigen v0.6.0 which would increase our minimum supported SDK version to Flutter 3.13. Therefore, I'm closing this and will create a new PR that uses method channels for Java. |
📜 Description
Adds session replay support for Flutter (Android, iOS)
💡 Motivation and Context
closes #1193
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps