From 4b33702623cb5ab3bb7c0ce9c9e146efbcd59776 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto Date: Sat, 13 Mar 2021 16:41:19 +0100 Subject: [PATCH 1/2] Fix: Pass hint to EventProcessors --- CHANGELOG.md | 1 + dart/lib/src/sentry_client.dart | 1 + dart/test/sentry_client_test.dart | 16 ++++++++++++++++ 3 files changed, 18 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d4f64c8c5e..42cb3c2261 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ * Bump: sentry-android to v4.3.0 (#343) * Fix: Multiple FlutterError.onError calls in FlutterErrorIntegration (#345) +* Fix: Pass hint to EventProcessors # 4.1.0-nullsafety.0 diff --git a/dart/lib/src/sentry_client.dart b/dart/lib/src/sentry_client.dart index 8da02d78b1..ac35127e22 100644 --- a/dart/lib/src/sentry_client.dart +++ b/dart/lib/src/sentry_client.dart @@ -72,6 +72,7 @@ class SentryClient { preparedEvent = await _processEvent( preparedEvent, eventProcessors: _options.eventProcessors, + hint: hint, ); // dropped by event processors diff --git a/dart/test/sentry_client_test.dart b/dart/test/sentry_client_test.dart index 0c99b0cd85..11c722a7c8 100644 --- a/dart/test/sentry_client_test.dart +++ b/dart/test/sentry_client_test.dart @@ -507,6 +507,22 @@ void main() { ); expect(event.fingerprint!.contains('process'), true); }); + + test('should pass hint to eventProcessors', () async { + final myHint = 'hint'; + var executed = false; + + options.addEventProcessor((event, {hint}) { + expect(myHint, hint); + executed = true; + return event; + }); + final client = SentryClient(options); + + await client.captureEvent(fakeEvent, hint: myHint); + + expect(executed, true); + }); }); } From b837605a55abeabbf232e673c429cec2b93aa9b4 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Date: Sat, 13 Mar 2021 16:42:46 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 42cb3c2261..ec58f49b6e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ * Bump: sentry-android to v4.3.0 (#343) * Fix: Multiple FlutterError.onError calls in FlutterErrorIntegration (#345) -* Fix: Pass hint to EventProcessors +* Fix: Pass hint to EventProcessors (#356) # 4.1.0-nullsafety.0