From 7d6a78847396f6189bd04f86ec27d9e2322b6ee2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Ueko=CC=88tter?= Date: Mon, 15 Mar 2021 07:50:37 +0100 Subject: [PATCH 1/2] Fix: Plugin registrant warning --- CHANGELOG.md | 1 + flutter/analysis_options.yaml | 1 + flutter/lib/{src => }/sentry_flutter_web.dart | 0 flutter/pubspec.yaml | 2 +- 4 files changed, 3 insertions(+), 1 deletion(-) rename flutter/lib/{src => }/sentry_flutter_web.dart (100%) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8fb497d629..8d348508ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ * Fix: Multiple FlutterError.onError calls in FlutterErrorIntegration (#345) * Fix: Pass hint to EventProcessors (#356) * Fix: EventProcessors were not dropping events when returning null (#353) +* Fix: Plugin Registrant class moved to barrel file (#314) # 4.1.0-nullsafety.0 diff --git a/flutter/analysis_options.yaml b/flutter/analysis_options.yaml index 6cc4aada60..a7b35bb79f 100644 --- a/flutter/analysis_options.yaml +++ b/flutter/analysis_options.yaml @@ -24,3 +24,4 @@ linter: rules: prefer_relative_imports: true unnecessary_brace_in_string_interps: true + implementation_imports: true diff --git a/flutter/lib/src/sentry_flutter_web.dart b/flutter/lib/sentry_flutter_web.dart similarity index 100% rename from flutter/lib/src/sentry_flutter_web.dart rename to flutter/lib/sentry_flutter_web.dart diff --git a/flutter/pubspec.yaml b/flutter/pubspec.yaml index a0c6285ab7..cdc481f122 100644 --- a/flutter/pubspec.yaml +++ b/flutter/pubspec.yaml @@ -39,4 +39,4 @@ flutter: pluginClass: SentryFlutterPlugin web: pluginClass: SentryFlutterWeb - fileName: src/sentry_flutter_web.dart + fileName: sentry_flutter_web.dart From a6a3e53c812f74fab52854051627074ec83dbc63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Ueko=CC=88tter?= Date: Mon, 15 Mar 2021 08:58:25 +0100 Subject: [PATCH 2/2] Improve changelog --- CHANGELOG.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d348508ec..cb68b87758 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,14 @@ * Fix: Multiple FlutterError.onError calls in FlutterErrorIntegration (#345) * Fix: Pass hint to EventProcessors (#356) * Fix: EventProcessors were not dropping events when returning null (#353) -* Fix: Plugin Registrant class moved to barrel file (#314) + + +## Breaking Changes: + +* Fix: Plugin Registrant class moved to barrel file (#358) + * This changed the import from `import 'package:sentry_flutter/src/sentry_flutter_web.dart';` + to `import 'package:sentry_flutter/sentry_flutter_web.dart';` + * This could lead to breaking changes. Typically it shouldn't because the referencing file is auto-generated. # 4.1.0-nullsafety.0