From 4b2adb3a8c6e86134c8886f62e9c7b13fa9b68e3 Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Fri, 18 Oct 2024 14:18:39 +0200 Subject: [PATCH] Revert "docs(js): Fix default integration examples (#11577)" This reverts commit 53c5a63cce342d5a07d59becd1b50481b0c28ca1. --- .../multiple-sentry-instances.mdx | 38 +++++++++---------- .../best-practices/shared-environments.mdx | 15 +++++--- 2 files changed, 27 insertions(+), 26 deletions(-) diff --git a/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx b/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx index 023eaee70d9e97..d2fc2efe087a7b 100644 --- a/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx +++ b/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx @@ -37,19 +37,18 @@ import { Scope, } from "@sentry/browser"; +// filter integrations that use the global variable +const integrations = getDefaultIntegrations({}).filter((defaultIntegration) => { + return !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes( + defaultIntegration.name + ); +}); const client = new BrowserClient({ dsn: "___PUBLIC_DSN___", transport: makeFetchTransport, stackParser: defaultStackParser, - // filter integrations that use the global variable - integrations: (defaultIntegrations) => - defaultIntegrations.filter( - (integration) => - !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes( - integration.name - ) - ), + integrations: integrations, }); const scope = new Scope(); @@ -90,18 +89,20 @@ function happyIntegration() { }; } +// filter integrations that use the global variable +const integrations = Sentry.getDefaultIntegrations({}).filter( + (defaultIntegration) => { + return !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes( + defaultIntegration.name + ); + } +); const client1 = new Sentry.BrowserClient({ dsn: "___PUBLIC_DSN___", transport: Sentry.makeFetchTransport, stackParser: Sentry.defaultStackParser, - // filter integrations that use the global variable - integrations: (defaultIntegrations) => [ - ...defaultIntegrations.filter( - (integration) => !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes(integration.name) - ), - happyIntegration(), - ], + integrations: [...integrations, happyIntegration()], beforeSend(event) { console.log("client 1", event); return null; // Returning `null` prevents the event from being sent @@ -114,12 +115,7 @@ const client2 = new Sentry.BrowserClient({ dsn: "___PUBLIC_DSN___", // Can be a different DSN transport: Sentry.makeFetchTransport, stackParser: Sentry.defaultStackParser, - integrations: (defaultIntegrations) => [ - ...defaultIntegrations.filter( - (integration) => !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes(integration.name) - ), - happyIntegration(), - ], + integrations: [...integrations, happyIntegration()], beforeSend(event) { console.log("client 2", event); return null; // Returning `null` prevents the event from being sent diff --git a/docs/platforms/javascript/common/best-practices/shared-environments.mdx b/docs/platforms/javascript/common/best-practices/shared-environments.mdx index a5b91187092ce0..5de050f9b93302 100644 --- a/docs/platforms/javascript/common/best-practices/shared-environments.mdx +++ b/docs/platforms/javascript/common/best-practices/shared-environments.mdx @@ -59,15 +59,20 @@ import { Scope, } from "@sentry/browser"; +// filter integrations that use the global variable +const integrations = getDefaultIntegrations({}).filter((defaultIntegration) => { + return ![ + "BrowserApiErrors", + "Breadcrumbs", + "GlobalHandlers", + ].includes(defaultIntegration.name); +}); + const client = new BrowserClient({ dsn: "___PUBLIC_DSN___", transport: makeFetchTransport, stackParser: defaultStackParser, - // filter integrations that use the global variable - integrations: (defaultIntegrations) => - defaultIntegrations.filter( - (integration) => !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes(integration.name) - ), + integrations: integrations, }); const scope = new Scope();