From c3eaab328a4465d0341badf7b4008b227aeb1847 Mon Sep 17 00:00:00 2001 From: Joris Bayer Date: Wed, 8 Jan 2025 16:26:09 +0100 Subject: [PATCH 1/3] Clarify limitations of attachment scrubbing --- .../scrubbing/attachment-scrubbing.mdx | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx b/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx index 4fdee91ae6277..bc7e2b1a4b830 100644 --- a/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx +++ b/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx @@ -32,7 +32,18 @@ All attachments can be selected using the `$attachments` [Value Type](../advance The filename must be in quotes to write a specific filename, but wildcards can also be used. For example, for the filename `minidump.dmp`, you can select all fields to be scrubbed using `$attachments.'minidump.dmp'.**`. -To write the same using a wildcard to select all attachments, you would write `$attachments.*.**` or even simply `$attachments.**`. +To write the same using a wildcard to select attachments with a specific file name, you would write `$attachments.'my_file.txt'.**` or even simply `$attachments.'my_file.txt'`. + + + +Sentry currently only has limited support for scrubbing attachments that are not minidumps. Only attachments that are explicitly selected by an [Advanced Data Scrubbing](../advanced-datascrubbing/) rule with a non-wildcard filename will actually be scrubbed. That is: + +``` +[Remove] [IP Addresses] from [$attachments.'foo.txt'] # will be scrubbed +[Remove] [IP Addresses] from [$attachments.**] # will *not* be scrubbed +``` + + ### Minidump Selectors From 79679d2b14edd01c732a12480e13c5317f33dc1e Mon Sep 17 00:00:00 2001 From: Joris Bayer Date: Wed, 8 Jan 2025 16:48:24 +0100 Subject: [PATCH 2/3] reformat comment --- docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx b/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx index bc7e2b1a4b830..dcdb4c5f3114f 100644 --- a/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx +++ b/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx @@ -39,8 +39,11 @@ To write the same using a wildcard to select attachments with a specific file na Sentry currently only has limited support for scrubbing attachments that are not minidumps. Only attachments that are explicitly selected by an [Advanced Data Scrubbing](../advanced-datascrubbing/) rule with a non-wildcard filename will actually be scrubbed. That is: ``` -[Remove] [IP Addresses] from [$attachments.'foo.txt'] # will be scrubbed -[Remove] [IP Addresses] from [$attachments.**] # will *not* be scrubbed +# Will be scrubbed: +[Remove] [IP Addresses] from [$attachments.'foo.txt'] + +# Will NOT be scrubbed: +[Remove] [IP Addresses] from [$attachments.**] ``` From 9ff6bd2a057a417360e6928d45022a2df27e06ae Mon Sep 17 00:00:00 2001 From: Joris Bayer Date: Thu, 9 Jan 2025 08:55:32 +0100 Subject: [PATCH 3/3] Update docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx Co-authored-by: David Herberth --- docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx b/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx index dcdb4c5f3114f..d2557e1a26704 100644 --- a/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx +++ b/docs/security-legal-pii/scrubbing/attachment-scrubbing.mdx @@ -36,7 +36,7 @@ To write the same using a wildcard to select attachments with a specific file na -Sentry currently only has limited support for scrubbing attachments that are not minidumps. Only attachments that are explicitly selected by an [Advanced Data Scrubbing](../advanced-datascrubbing/) rule with a non-wildcard filename will actually be scrubbed. That is: +Sentry currently only has limited support for scrubbing attachments that are not minidumps. Only attachments that are explicitly selected by an [Advanced Data Scrubbing](../advanced-datascrubbing/) rule with a non-wildcard filename will actually be scrubbed. For example: ``` # Will be scrubbed: