feat: update docs for profiling v2 #13197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
armcknight
changed the title
armcknight
changed the title
3 tasks
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
sfanahata
reviewed
Apr 2, 2025
Member
Author
|
Tracking the release of the associated feature at getsentry/sentry-cocoa#4952 |
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
sfanahata
reviewed
Apr 3, 2025
Contributor
|
@armcknight Looks good overall. I left a few suggestions to make the wording a bit clearer. |
sfanahata
approved these changes
Apr 3, 2025
Contributor
sfanahata
left a comment
sfanahata
left a comment
There was a problem hiding this comment.
Nothing blocking, but some changes I suggested for clarity would be helpful.
indragiek
requested changes
Apr 4, 2025
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
6 tasks
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
* feat(profiling[cocoa]): update docs for profiling v2 * add example of manual profiling * improve table view example * Update docs/platforms/apple/common/profiling/index.mdx Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com> * Update docs/platforms/apple/common/profiling/index.mdx Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com> * Update docs/platforms/apple/common/profiling/index.mdx Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com> * Apply suggestions from code review Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com> * pr feedback * more feedback --------- Co-authored-by: Shannon Anahata <shannon.anahata@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Update the Apple profiling docs to explain the new iteration of profiling and the deprecation of all prior versions of the API.
For getsentry/sentry-cocoa#4996
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES