Skip to content

Conversation

@Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Apr 4, 2025

DESCRIBE YOUR PR

This updates the profiling docs for python to make continuous profiling the default.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline April 9
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

This updates the profiling docs for python to make continuous profiling the
default.
@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 5:45pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 5:45pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 5:45pm

@Zylphrex Zylphrex requested a review from a team April 4, 2025 20:20
@codecov
Copy link

codecov bot commented Apr 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/bgvr44FgnbL8uSllSGDx9/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/bgvr44FgnbL8uSllSGDx9/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/x5yTrnpXyNeH9fdtMQijR/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/x5yTrnpXyNeH9fdtMQijR/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@Zylphrex Zylphrex requested a review from a team April 4, 2025 21:18
…docs/update-python-continuous-profiling-docs
@Zylphrex Zylphrex requested a review from coolguyzone April 9, 2025 20:36
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added some suggestions, good to go.

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
…docs/update-python-continuous-profiling-docs
…docs/update-python-continuous-profiling-docs
…docs/update-python-continuous-profiling-docs
@indragiek indragiek merged commit 51626b2 into master Apr 14, 2025
11 checks passed
@indragiek indragiek deleted the txiao/docs/update-python-continuous-profiling-docs branch April 14, 2025 17:53
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* docs(python): Update python continuous profiling docs

This updates the profiling docs for python to make continuous profiling the
default.

* address feedback

* fix links

* fix typos

* Apply suggestions from code review

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>

* Update docs/platforms/python/profiling/index.mdx

---------

Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Indragie Karunaratne <indragie.karunaratne@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants