Skip to content

Conversation

@cleptric
Copy link
Member

@cleptric cleptric commented Sep 1, 2025

closes #1893
closes PHP-22

@cleptric cleptric self-assigned this Sep 1, 2025
@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 18, 2025 3:35pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 18, 2025 3:35pm

@codecov
Copy link

codecov bot commented Sep 1, 2025

Bundle Report

Changes will increase total bundle size by 375.28kB (1.62%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.17MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 13.0MB 375.28kB (2.97%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 125.1kB 897.29kB 16.2% ⚠️
../app/platform-redirect/page.js.nft.json 125.1kB 897.21kB 16.2% ⚠️
../app/sitemap.xml/route.js.nft.json 125.1kB 894.43kB 16.26% ⚠️
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/VesiAPSeTIlsjl71ai6h6/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/VesiAPSeTIlsjl71ai6h6/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/QzoTakWegZllKlhPiF1jR/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/QzoTakWegZllKlhPiF1jR/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@linear
Copy link

linear bot commented Sep 8, 2025

$logger = new Logger('sentry_logs');
$logger->pushHandler(new \Sentry\Monolog\LogsHandler(
LogLevel::info(), // Minimum level to send logs
));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Sentry Monolog LogsHandler: Parameter Mismatch

The LogsHandler is instantiated with incorrect parameters. It uses LogLevel::info() from Sentry\Logs\LogLevel (called as a method with parentheses) instead of Monolog\Level::Info, and it's missing the hub parameter with named arguments. Other Sentry Monolog handlers in the same file (BreadcrumbHandler and Handler) consistently use named parameters with hub: \Sentry\SentrySdk::getCurrentHub() and level: Level::Info, which is the correct pattern.

Fix in Cursor Fix in Web

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LogsHandler uses (LogLevel, bool) in the constructor. This comment would be correct for BreadcrumbHandler which uses a different signature

@Litarnus Litarnus requested a review from a team November 11, 2025 13:48
Copy link
Contributor

@dingsdax dingsdax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@Litarnus Litarnus merged commit 94060a3 into master Nov 24, 2025
14 checks passed
@Litarnus Litarnus deleted the php-monolog branch November 24, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Docs for Monolog Logs

4 participants