From 9a5539d1fda0bb2c9d4d8cca8a846399e221a993 Mon Sep 17 00:00:00 2001 From: Abdellah Hariti Date: Fri, 24 Oct 2025 18:50:43 +0100 Subject: [PATCH 1/4] change gh action cache logic --- .github/workflows/lint-404s.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint-404s.yml b/.github/workflows/lint-404s.yml index 1015b88dd6971e..0f29820c06f1fb 100644 --- a/.github/workflows/lint-404s.yml +++ b/.github/workflows/lint-404s.yml @@ -36,12 +36,11 @@ jobs: ${{ github.workspace }}/node_modules ${{ github.workspace }}/.next/cache ${{ github.workspace }}/.eslintcache - key: node-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }} + key: node-${{ runner.os }}-${{ steps.setup-node.outputs.node-version }}-${{ hashFiles('**/yarn.lock') }} restore-keys: | - node-${{ runner.os }}- + node-${{ runner.os }}-${{ steps.setup-node.outputs.node-version }}- - run: yarn install --frozen-lockfile - if: steps.cache.outputs.cache-hit != 'true' - run: yarn build if: steps.filter.outputs.docs == 'true' @@ -50,7 +49,8 @@ jobs: NEXT_PUBLIC_SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 - run: yarn build:developer-docs - if: steps.filter.outputs.dev-docs == 'true' + # short circuit for now + # if: steps.filter.outputs.dev-docs == 'true' env: SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 NEXT_PUBLIC_SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 From 8e36b9f84aa5634212560b74569d331be295ae91 Mon Sep 17 00:00:00 2001 From: Abdellah Hariti Date: Fri, 24 Oct 2025 18:59:42 +0100 Subject: [PATCH 2/4] more shortcuts --- .github/workflows/lint-404s.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-404s.yml b/.github/workflows/lint-404s.yml index 0f29820c06f1fb..defd44f011bb01 100644 --- a/.github/workflows/lint-404s.yml +++ b/.github/workflows/lint-404s.yml @@ -57,14 +57,14 @@ jobs: - name: Start Http Server run: yarn start & - if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' + # if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' env: SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 NEXT_PUBLIC_SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 - name: Lint 404s run: bun ./scripts/lint-404s/main.ts - if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' + # if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' - name: Kill Http Server run: kill $(lsof -t -i:3000) || true From f774936b7fd31be58310188ab56ae9ba2ca5dad2 Mon Sep 17 00:00:00 2001 From: Abdellah Hariti Date: Fri, 24 Oct 2025 19:06:24 +0100 Subject: [PATCH 3/4] reenable step condition checks --- .github/workflows/lint-404s.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint-404s.yml b/.github/workflows/lint-404s.yml index defd44f011bb01..e53abb8fcbda68 100644 --- a/.github/workflows/lint-404s.yml +++ b/.github/workflows/lint-404s.yml @@ -49,22 +49,21 @@ jobs: NEXT_PUBLIC_SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 - run: yarn build:developer-docs - # short circuit for now - # if: steps.filter.outputs.dev-docs == 'true' + if: steps.filter.outputs.dev-docs == 'true' env: SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 NEXT_PUBLIC_SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 - name: Start Http Server run: yarn start & - # if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' + if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' env: SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 NEXT_PUBLIC_SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0 - name: Lint 404s run: bun ./scripts/lint-404s/main.ts - # if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' + if: steps.filter.outputs.docs == 'true' || steps.filter.outputs.dev-docs == 'true' - name: Kill Http Server run: kill $(lsof -t -i:3000) || true From 24f1ee572f661e5e6831f5647576d555775a54a4 Mon Sep 17 00:00:00 2001 From: Abdellah Hariti Date: Fri, 24 Oct 2025 22:22:29 +0100 Subject: [PATCH 4/4] lean up build command --- .github/workflows/lint-404s.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint-404s.yml b/.github/workflows/lint-404s.yml index e53abb8fcbda68..40ba604c47da95 100644 --- a/.github/workflows/lint-404s.yml +++ b/.github/workflows/lint-404s.yml @@ -42,7 +42,7 @@ jobs: - run: yarn install --frozen-lockfile - - run: yarn build + - run: yarn next build if: steps.filter.outputs.docs == 'true' env: SENTRY_DSN: https://examplePublicKey@o0.ingest.sentry.io/0