Skip to content

Conversation

@jaffrepaul
Copy link
Contributor

@jaffrepaul jaffrepaul commented Nov 19, 2025

DESCRIBE YOUR PR

This fixes a nuanced regex issue that was creating cases where keywords were converting correctly in some places but not in other instances on the same page.

The regex here uses a global flag which is stateful and each regex .test() call inherits lastIndex from the previous call. If lastIndex > string.length, the test fails and doesn't convert the keyword. This small update makes sure every .test() call starts fresh with lastIndex = 0 so every string is searched from the beginning.

PROD: https://docs.sentry.io/product/drains/integration/vercel/
PREVIEW: https://sentry-docs-git-stale-keyword-fix.sentry.dev/product/drains/integration/vercel/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Nov 19, 2025 11:20pm
sentry-docs Ready Ready Preview Comment Nov 19, 2025 11:20pm

@codecov
Copy link

codecov bot commented Nov 19, 2025

Bundle Report

Changes will increase total bundle size by 183.33kB (0.79%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.17MB 22 bytes (0.0%) ⬆️
sentry-docs-server-cjs* 12.81MB 183.31kB (1.45%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/app/[[...path]]/page-*.js 28 bytes 95.95kB 0.03%
static/iWyPniwUCB1yQ9n7Ty7_8/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/iWyPniwUCB1yQ9n7Ty7_8/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/irNisoLwdOGnzKmxF2aki/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/irNisoLwdOGnzKmxF2aki/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 61.1kB 831.97kB 7.93% ⚠️
../app/platform-redirect/page.js.nft.json 61.1kB 831.89kB 7.93% ⚠️
../app/sitemap.xml/route.js.nft.json 61.1kB 829.12kB 7.95% ⚠️
../app/[[...path]]/page.js 30 bytes 619.97kB 0.0%

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 30 bytes 3.37MB 0.0%

@jaffrepaul jaffrepaul changed the title fix: eliminate regex lastIndex issues with matchAll() fix: reset regex lastIndex to prevent keyword matching failures Nov 19, 2025
@jaffrepaul jaffrepaul marked this pull request as ready for review November 19, 2025 23:50
@jaffrepaul jaffrepaul requested a review from sergical November 20, 2025 00:00
Copy link
Member

@sergical sergical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jaffrepaul jaffrepaul merged commit 55de496 into master Nov 20, 2025
17 checks passed
@jaffrepaul jaffrepaul deleted the stale-keyword-fix branch November 20, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants