docs(sourceMaps): Add filesToDeleteAfterUpload when source maps are enabled
#15609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 3.98kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Lms24
approved these changes
Nov 25, 2025
| sourcemaps: { | ||
| // As you're enabling client source maps, you probably want to delete them after they're uploaded to Sentry. | ||
| // Set the appropriate glob pattern for your output folder - some glob examples below: | ||
| filesToDeleteAfterUpload: ['.*/**/public/**/*.map', './dist/**/client/**/*.map'] |
Member
There was a problem hiding this comment.
general question: Should we show the simple ./**/*.map glob pattern instead of these paths? I don't think the paths here necessarily apply to most apps (especially frontend-only frameworks) and the catchall glob pattern would ensure things work even if users just blindly copy the snippet.
No strong opinion, so not a blocker for me. just a tought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Follow-up on this PR: #15574
In snippets, where source maps are enabled, the
filesToDeleteAfterUploadoption is added as well. Also, the section about adding this option is added as a warning, not a simple note.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: