-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update Sentry SDK integration instructions for frontend: generalize p… #15614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ackage manager reference and remove unnecessary whitespace.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jaffrepaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
| // https://docs.sentry.io/platforms/javascript/session-replay/configuration/#general-integration-configuration | ||
| replaysSessionSampleRate: 0.1, | ||
| replaysOnErrorSampleRate: 1.0, | ||
| ${<Include name="code-comments/javascript/trace-sample-rate" />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should still have traceSampleRate: 1 in here, it just seems like code-comments isn't something we have anymore 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes. I misunderstood what was happening here 😅 having tracing present is def something we should include.
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
This pull request updates the Sentry integration documentation for frontend applications to improve clarity and remove unnecessary code comments. The most important changes are:
Documentation clarity improvements:
docs/product/sentry-basics/integrate-frontend/initialize-sentry-sdk.mdx.Code cleanup:
docs/product/sentry-basics/integrate-frontend/initialize-sentry-sdk.mdx.