From 8219259a24ced1e3adc17ea363466bb5da6441e5 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 23 Jan 2024 10:32:44 +0100 Subject: [PATCH] Fix guarding for event id in showReportDialog docs --- .../user-feedback/example-widget/javascript.electron.mdx | 4 ++-- .../user-feedback/example-widget/javascript.mdx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/platform-includes/user-feedback/example-widget/javascript.electron.mdx b/src/platform-includes/user-feedback/example-widget/javascript.electron.mdx index 44ada7c9f9e50..7dc9a49a813a8 100644 --- a/src/platform-includes/user-feedback/example-widget/javascript.electron.mdx +++ b/src/platform-includes/user-feedback/example-widget/javascript.electron.mdx @@ -8,8 +8,8 @@ init({ beforeSend(event) { // Check if it is an exception, if so, show the report dialog // Note that this only will work in the renderer process, it's a noop on the main process - if (event.exception) { - showReportDialog(); + if (event.exception && event.event_id) { + showReportDialog({ eventId: event_id }); } return event; }, diff --git a/src/platform-includes/user-feedback/example-widget/javascript.mdx b/src/platform-includes/user-feedback/example-widget/javascript.mdx index 132b49d7905ef..6bd0f3bd85e28 100644 --- a/src/platform-includes/user-feedback/example-widget/javascript.mdx +++ b/src/platform-includes/user-feedback/example-widget/javascript.mdx @@ -8,7 +8,7 @@ If you're using a framework like [React](/platforms/javascript/guides/react/) or dsn: "___PUBLIC_DSN___", beforeSend(event, hint) { // Check if it is an exception, and if so, show the report dialog - if (event.exception) { + if (event.exception && event.event_id) { Sentry.showReportDialog({ eventId: event.event_id }); } return event;