Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logging on body not extracted #246

Merged
merged 1 commit into from Jul 27, 2019
Merged

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jul 21, 2019

Don't log warning if extracting body data was not opt'ed-in

@codecov-io
Copy link

codecov-io commented Jul 21, 2019

Codecov Report

Merging #246 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #246     +/-   ##
=========================================
- Coverage   89.28%   89.19%   -0.1%     
=========================================
  Files          81       81             
  Lines        2035     2036      +1     
=========================================
- Hits         1817     1816      -1     
- Misses        218      220      +2
Impacted Files Coverage Δ
...y/Extensibility/RequestBodyExtractionDispatcher.cs 100% <100%> (ø) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 94.26% <0%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ec03e...a4e3223. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 46bf554 into master Jul 27, 2019
@bruno-garcia bruno-garcia deleted the fix/logging-ignore-body branch July 27, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants