Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating fullstory module and adding rollup-based build #1

Merged
merged 2 commits into from Nov 13, 2019

Conversation

@patrick-fs
Copy link
Collaborator

patrick-fs commented Nov 8, 2019

Hey Steve,

I have:

  • updated the FullStory module code to look like our forthcoming @fullstorydev/browser NPM package
  • added some basic rollup build config

I haven't actually tested this yet, but wanted to get your eyes on it for review. I won't merge into develop without running a smoke test first.

@patrick-fs patrick-fs added the proposal label Nov 8, 2019
@patrick-fs patrick-fs changed the title updating fullstory module and adding rollup-based bulid updating fullstory module and adding rollup-based build Nov 8, 2019
@scefali

This comment has been minimized.

Copy link
Collaborator

scefali commented Nov 8, 2019

@patrick-fs Looks good to me. On a side note, what do you think about using Typescript (at least for the interfaces)? At Sentry we are currently migrating to TS and I think it's pretty standard for packages these days.

@scefali scefali self-requested a review Nov 8, 2019
@patrick-fs

This comment has been minimized.

Copy link
Collaborator Author

patrick-fs commented Nov 8, 2019

@scefali I'm very pro-TypeScript!

@scefali
scefali approved these changes Nov 8, 2019
@patrick-fs patrick-fs merged commit bf947b2 into develop Nov 13, 2019
@patrick-fs patrick-fs removed the proposal label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.