Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FullStory reference #23

Merged
merged 4 commits into from Feb 4, 2020
Merged

Update FullStory reference #23

merged 4 commits into from Feb 4, 2020

Conversation

@patrick-fs
Copy link
Collaborator

patrick-fs commented Feb 4, 2020

Hello! We've recently acquired the @fullstory NPM org and thus have updated our package to @fullstory/browser from @fullstorydev/browser

This PR updates package.json, yarn.lock, and the import statement to point to the new org.

"@sentry/browser": ">=4.0.0"
},
"dependencies": {},
"devDependencies": {
"@babel/core": "^7.7.2",
"@fullstorydev/browser": "^2.0.0",
"@fullstory/browser": "^1.0.0",

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Feb 4, 2020

Author Collaborator

@scefali I noticed this devDependancy and updated it. Is this devDep required though?

This comment has been minimized.

Copy link
@scefali

scefali Feb 4, 2020

Contributor

@patrick-fs We use devDependencies so dependencies resolve when testing locally and writing the code. So yes, we need it.

Copy link
Contributor

scefali left a comment

@patrick-fs Need to update the changelog file with this change for the future version. Don't worry about updating the package.json to the new version, however. The tool we use will automatically do that.

@patrick-fs

This comment has been minimized.

Copy link
Collaborator Author

patrick-fs commented Feb 4, 2020

@patrick-fs Need to update the changelog file with this change for the future version. Don't worry about updating the package.json to the new version, however. The tool we use will automatically do that.

@scefali this is done. Thanks for the reminder about the changelog.

@scefali
scefali approved these changes Feb 4, 2020
@scefali

This comment has been minimized.

Copy link
Contributor

scefali commented Feb 4, 2020

@patrick-fs Feel free to merge. I'm going to try to resolve #16 in this release as well.

@patrick-fs patrick-fs merged commit 5b19fe7 into master Feb 4, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@patrick-fs patrick-fs deleted the patrick/fullstory_dep_update branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.