Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not clone the hub inside StartTransaction #505

merged 1 commit into from Dec 5, 2022


Copy link

@cleptric cleptric commented Nov 30, 2022

Cloning the Hub inside StartTransaction is not necessary and can mess up the scope.
Calling sentry.Init() already creates the "initial" hub, integrations have to make sure to attach it to the context.

Closes #502

@cleptric cleptric self-assigned this Nov 30, 2022
@cleptric cleptric marked this pull request as ready for review December 5, 2022 10:21
@cleptric cleptric requested a review from phacops December 5, 2022 10:21
@cleptric cleptric merged commit 5dbb801 into master Dec 5, 2022
13 checks passed
@cleptric cleptric deleted the fix-start-transaction branch December 5, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

captureException not linking to trace
2 participants