From ce182a19fdc093ce6d15bef27921b8b5f59cea07 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 2 Jun 2023 15:34:51 +0200 Subject: [PATCH 1/2] fix: stack-trace in_app false being omitted --- stacktrace.go | 2 +- stacktrace_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/stacktrace.go b/stacktrace.go index c3c5f5d55..81afbf3cf 100644 --- a/stacktrace.go +++ b/stacktrace.go @@ -174,7 +174,7 @@ type Frame struct { PreContext []string `json:"pre_context,omitempty"` ContextLine string `json:"context_line,omitempty"` PostContext []string `json:"post_context,omitempty"` - InApp bool `json:"in_app,omitempty"` + InApp bool `json:"in_app"` Vars map[string]interface{} `json:"vars,omitempty"` // Package and the below are not used for Go stack trace frames. In // other platforms it refers to a container where the Module can be diff --git a/stacktrace_test.go b/stacktrace_test.go index 2a4a9c20a..cb6f4f687 100644 --- a/stacktrace_test.go +++ b/stacktrace_test.go @@ -230,6 +230,7 @@ func TestEventWithExceptionStacktraceMarshalJSON(t *testing.T) { `"vars":{"fooint":25,"foostr":"bar"}` + `},{` + `"symbol":"nativesym",` + + `"in_app":false,` + `"package":"my.dylib",` + `"instruction_addr":"0xabcd0010",` + `"addr_mode":"abs",` + From c77c625df7242c64b49548e633e7eaf0c38cfb7a Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Fri, 2 Jun 2023 15:38:03 +0200 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 02c783db8..ee99ccaf9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Bug fixes + +- Fix frames recognized as not being in-app still showing as in-app ([#647](https://github.com/getsentry/sentry-go/pull/647)) + ## 0.21.0 The Sentry SDK team is happy to announce the immediate availability of Sentry Go SDK v0.21.0.