From 2df5bb697822998aa4c88ed95b1db427a89ee6fc Mon Sep 17 00:00:00 2001 From: Roman Zavarnitsyn Date: Tue, 8 Feb 2022 12:40:40 +0100 Subject: [PATCH] Add breaking change note about Timber.tag --- CHANGELOG.md | 4 ++++ .../main/java/io/sentry/android/timber/SentryTimberTree.kt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ae3bf9d98..9a97f543c3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ * Fix: Do not include stacktrace frames into Timber message (#1898) +Breaking changes: +`Timber.tag` is no longer supported by our [Timber integration](https://docs.sentry.io/platforms/android/configuration/integrations/timber/) and will not appear on Sentry for error events. +Please vote on this [issue](https://github.com/getsentry/sentry-java/issues/1900), if you'd like us to provide support for that. + ## 5.6.1 * Fix: NPE while adding "response_body_size" breadcrumb, when response body is null (#1884) diff --git a/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt b/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt index d8e4d6a1a3..282573647c 100644 --- a/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt +++ b/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt @@ -199,8 +199,8 @@ class SentryTimberTree( val level = getSentryLevel(priority) val sentryMessage = Message().apply { this.message = message - if (message != null && args.isNotEmpty()) { - this.formatted = message.format(*args) + if (!message.isNullOrEmpty() && args.isNotEmpty()) { + this.formatted = message?.format(*args) } this.params = args.map { it.toString() } }