From 7e644905559209566b64cf7bb37358b98b6c5682 Mon Sep 17 00:00:00 2001 From: Nikita Seleznev Date: Thu, 24 Feb 2022 13:56:52 +0100 Subject: [PATCH] Fix NPE while adding "response_body_size" breadcrumb (#1907) (#1908) Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Co-authored-by: Roman Zavarnitsyn --- CHANGELOG.md | 2 ++ .../src/main/java/io/sentry/openfeign/SentryFeignClient.java | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e119fbb59..4e3c7e43cc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +* Fix: NPE while adding "response_body_size" breadcrumb, when response body length is unknown (#1908) + ## 5.6.2-beta.1 * Fix: Do not include stacktrace frames into Timber message (#1898) diff --git a/sentry-openfeign/src/main/java/io/sentry/openfeign/SentryFeignClient.java b/sentry-openfeign/src/main/java/io/sentry/openfeign/SentryFeignClient.java index 8c8c5582b0..c8ea6a3f92 100644 --- a/sentry-openfeign/src/main/java/io/sentry/openfeign/SentryFeignClient.java +++ b/sentry-openfeign/src/main/java/io/sentry/openfeign/SentryFeignClient.java @@ -84,9 +84,8 @@ private void addBreadcrumb(final @NotNull Request request, final @Nullable Respo request.httpMethod().name(), response != null ? response.status() : null); breadcrumb.setData("request_body_size", request.body() != null ? request.body().length : 0); - if (response != null) { - breadcrumb.setData( - "response_body_size", response.body() != null ? response.body().length() : 0); + if (response != null && response.body() != null && response.body().length() != null) { + breadcrumb.setData("response_body_size", response.body().length()); } hub.addBreadcrumb(breadcrumb); }