Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach-screenshot set on Manual init. didn't work #2186

Merged
merged 6 commits into from Aug 1, 2022

Conversation

marandaneto
Copy link
Contributor

馃摐 Description

attach-screenshot set on Manual init. didn't work

馃挕 Motivation and Context

Fix #2185

馃挌 How did you test it?

Running and unit tests

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #2186 (404799b) into main (ec4beec) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2186   +/-   ##
=========================================
  Coverage     80.91%   80.91%           
  Complexity     3313     3313           
=========================================
  Files           236      236           
  Lines         12154    12154           
  Branches       1615     1615           
=========================================
  Hits           9834     9834           
  Misses         1725     1725           
  Partials        595      595           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ec4beec...404799b. Read the comment docs.

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one question on the test

@marandaneto marandaneto enabled auto-merge (squash) August 1, 2022 07:38
@marandaneto marandaneto merged commit f75a0a7 into main Aug 1, 2022
@marandaneto marandaneto deleted the fix/attach-screenshot-manual branch August 1, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attach-screenshot on manual Android init
3 participants