Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Logback Appender #33

Merged
merged 7 commits into from Jan 23, 2013

Conversation

Projects
None yet
3 participants
Contributor

ccouturi commented Dec 17, 2012

Add Sentry appender for Logback logger

Contributor

roam commented Jan 16, 2013

LogbackMDC uses org.slf4j.MDC, but the slf4j dependency is scoped for testing only. I'm not familiar with Logback and its numerous modules, so I'm not going to make the call on slf4j's scope for the raven-logback module.

Contributor

ccouturi commented Jan 21, 2013

Thanks roam, you're right. I have changed the scope of slf4j dependency.

@roam roam merged commit 283402b into getsentry:refactoring Jan 23, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Contributor

roam commented Jan 23, 2013

Thanks for the contribution! I've changed a few things in the master branch:

  • Clean up of the included readme file
  • Removal of the unused encoder property in SentryAppender. Tests still work so I assume this really isn't necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment