Skip to content

Conversation

@adinauer
Copy link
Member

#skip-changelog

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b433348

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 435.10 ms 439.45 ms 4.35 ms
Size 1.65 MiB 2.31 MiB 673.06 KiB

Previous results on branch: feat/otel-spring-boot-2-sample

Startup times

Revision Plain With Sentry Diff
bc66261 435.21 ms 505.44 ms 70.23 ms
a875a80 412.33 ms 435.26 ms 22.93 ms

App size

Revision Plain With Sentry Diff
bc66261 1.65 MiB 2.31 MiB 672.90 KiB
a875a80 1.65 MiB 2.31 MiB 672.90 KiB

Base automatically changed from feat/spring-boot-2-otel to 8.x.x November 12, 2024 13:52
include:
- sample: "sentry-samples-spring-boot"
- sample: "sentry-samples-spring-boot-opentelemetry-noagent"
- sample: "sentry-samples-spring-boot-opentelemetry"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to have a test with agent-auto-init: "false" like for spring boot 3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@adinauer adinauer merged commit 161184c into 8.x.x Nov 13, 2024
35 checks passed
@adinauer adinauer deleted the feat/otel-spring-boot-2-sample branch November 13, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants