Skip to content

Conversation

@markushi
Copy link
Member

📜 Description

SentryTimberTree wrongly calls super.d, instead of super.i.

override fun i(message: String?, vararg args: Any?) {
  super.d(message, *args)
       ^^^
}

💡 Motivation and Context

💚 How did you test it?

Added unit tests

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@markushi markushi changed the title Fix faulty super call Fix wrong .super() call in SentryTimberTree Oct 28, 2025
@markushi
Copy link
Member Author

@sentry review

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 349.28 ms 410.76 ms 61.48 ms
Size 1.58 MiB 2.12 MiB 551.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d217708 375.27 ms 415.68 ms 40.41 ms
ee747ae 405.43 ms 485.70 ms 80.28 ms
3d205d0 352.15 ms 432.53 ms 80.38 ms
b3d8889 371.33 ms 426.24 ms 54.92 ms
27d7cf8 309.43 ms 364.27 ms 54.85 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
c8125f3 383.82 ms 441.66 ms 57.84 ms
bdbe1f4 380.66 ms 464.44 ms 83.78 ms
f634d01 375.06 ms 420.04 ms 44.98 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms

App size

Revision Plain With Sentry Diff
d217708 1.58 MiB 2.10 MiB 532.97 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
b3d8889 1.58 MiB 2.10 MiB 535.07 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
bdbe1f4 1.58 MiB 2.11 MiB 538.88 KiB
f634d01 1.58 MiB 2.10 MiB 533.40 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

@markushi markushi changed the title Fix wrong .super() call in SentryTimberTree fix(timber): wrong .super() call in SentryTimberTree Oct 29, 2025
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, can't believe this was there for so long without anyone noticing 🙈

@markushi markushi merged commit 8c7e8d9 into main Oct 29, 2025
61 of 62 checks passed
@markushi markushi deleted the markushi/fix/wrong-timber-super-call branch October 29, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry <> Timber integration: Missing TimberTag tag

3 participants