Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task dependency to adapt Android App Bundle #707

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@chibatching
Copy link
Contributor

commented May 3, 2019

When we create App Bundle, sentry-debug-meta.properties aren't included in aab.
So, I added task dependency to run persisting proguard uuid before packaging aab bundles.

@chibatching chibatching changed the title Add task dependency to adapt App Bundle Add task dependency to adapt Android App Bundle Jun 19, 2019

@ninniuz

This comment has been minimized.

Copy link
Collaborator

commented Jul 20, 2019

@chibatching I can see the sentry-debug-meta.properties file in my aab file and in the generated apks, on AGP 3.4.2 and Sentry 1.7.24.

Are you sure this is still needed?

@chibatching

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

I'm still having this issue with Sentry 1.7.24 and both AGP 3.4.2 and 3.5-rc01.

First, I tried ./gradlew clean app:bundleRelease, sentry-debug-meta.properties is not included in aab.
Second, I tried just ./gradlew app:bundleRelease after first try, sentry-debug-meta.properties is successfully included.

The cause seems like the order of tasks bundlePreRelease and persistSentryProguardUuidsForReleaseRelease is not guaranteed.

@ninniuz

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

Ok I see what you mean. Since we are either saying that:

  • persistSentryProguardUuids task should be run before the dex task and after the proguard task, finalizing it (that means proguard -> persistSentryProguardUuids -> dex)
  • OR persistSentryProguardUuids should run after proguard task and finalize it
    then if the dex task is not run (as it appears to be with app bundled) we will get sentry-debug-meta.properties included only if the task completes before the bundle is packaged.

@bruno-garcia bruno-garcia self-requested a review Jul 22, 2019

@bruno-garcia bruno-garcia merged commit e41ced3 into getsentry:master Jul 22, 2019

19 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/snyk - pom.xml (sentry) No new issues
Details
license/snyk - sentry-android-gradle-plugin/build.gradle (sentry) No manifest changes detected
license/snyk - sentry-android/pom.xml (sentry) No new issues
Details
license/snyk - sentry-appengine/pom.xml (sentry) No new issues
Details
license/snyk - sentry-log4j/pom.xml (sentry) No new issues
Details
license/snyk - sentry-log4j2/pom.xml (sentry) No new issues
Details
license/snyk - sentry-logback/pom.xml (sentry) No new issues
Details
license/snyk - sentry-spring/pom.xml (sentry) No new issues
Details
license/snyk - sentry/pom.xml (sentry) No new issues
Details
security/snyk - pom.xml (sentry) No new issues
Details
security/snyk - sentry-android-gradle-plugin/build.gradle (sentry) No manifest changes detected
security/snyk - sentry-android/pom.xml (sentry) No new issues
Details
security/snyk - sentry-appengine/pom.xml (sentry) No new issues
Details
security/snyk - sentry-log4j/pom.xml (sentry) No new issues
Details
security/snyk - sentry-log4j2/pom.xml (sentry) No new issues
Details
security/snyk - sentry-logback/pom.xml (sentry) No new issues
Details
security/snyk - sentry-spring/pom.xml (sentry) No new issues
Details
security/snyk - sentry/pom.xml (sentry) No new issues
Details
@bruno-garcia

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Thanks @chibatching, @ninniuz !

@chibatching chibatching deleted the chibatching:add_task_dependency_for_app_bundle branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.