feat(sourcemaps): Replace "clean artifacts" command #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // eslint-disable-next-line @typescript-eslint/restrict-template-expressions, @typescript-eslint/no-unsafe-member-access | ||
| const USER_AGENT = `sentry-unplugin/${unpluginVersion}`; | ||
| const sentryApiAxiosInstance = axios.create(); |
vladanpaunovic
approved these changes
Aug 24, 2022
Contributor
vladanpaunovic
left a comment
vladanpaunovic
left a comment
There was a problem hiding this comment.
Ignoring TODOs, all good
Lms24
approved these changes
Aug 24, 2022
| authToken: string; | ||
| sentryUrl: string; | ||
| }): Promise<void> { | ||
| const requestUrl = `${sentryUrl}${API_PATH}/projects/${org}/${project}/releases/`; |
Member
There was a problem hiding this comment.
Suggested change
| const requestUrl = `${sentryUrl}${API_PATH}/projects/${org}/${project}/releases/`; | |
| // using the legacy endpoint here because the sentry webpack plugin only associates one project | |
| // with the release. If we ever wanna support multiple projects in the unplugin, | |
| // take a look at how sentry/cli calls the new endpoint: | |
| // https://github.com/getsentry/sentry-cli/blob/4fa813549cd249e77ae6ba974d76e606a19f48de/src/api.rs#L769-L773 | |
| const requestUrl = `${sentryUrl}${API_PATH}/projects/${org}/${project}/releases/`; |
packages/unplugin/src/sentry/api.ts
Outdated
Comment on lines
45
to
48
| // using the legacy endpoint here because the sentry webpack plugin only associates one project | ||
| // with the release. If we ever wanna support multiple projects in the unplugin, | ||
| // take a look at how sentry/cli calls the new endpoint: | ||
| // https://github.com/getsentry/sentry-cli/blob/4fa813549cd249e77ae6ba974d76e606a19f48de/src/api.rs#L769-L773 |
Member
There was a problem hiding this comment.
Suggested change
| // using the legacy endpoint here because the sentry webpack plugin only associates one project | |
| // with the release. If we ever wanna support multiple projects in the unplugin, | |
| // take a look at how sentry/cli calls the new endpoint: | |
| // https://github.com/getsentry/sentry-cli/blob/4fa813549cd249e77ae6ba974d76e606a19f48de/src/api.rs#L769-L773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.