From 2f17bb1ec69cf0f3da5117934021c8f14243f98b Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 21 Nov 2023 03:58:50 -0500 Subject: [PATCH] fix(astro): Remove method from span op (#9603) Although adding method is nice to span op, it duplicates information that is already in span description. In addition, we want to reduce the total list of span ops as much as possible for cardinality reasons, `http.server` + span data about method is good enough to understand intent here. --- packages/astro/src/server/middleware.ts | 2 +- packages/astro/test/server/middleware.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/astro/src/server/middleware.ts b/packages/astro/src/server/middleware.ts index c04618cad33f..b5b7aa7d8c71 100644 --- a/packages/astro/src/server/middleware.ts +++ b/packages/astro/src/server/middleware.ts @@ -83,7 +83,7 @@ export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseH const res = await startSpan( { name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`, - op: `http.server.${method.toLowerCase()}`, + op: 'http.server', origin: 'auto.http.astro', status: 'ok', ...traceparentData, diff --git a/packages/astro/test/server/middleware.test.ts b/packages/astro/test/server/middleware.test.ts index 058982f06cc6..59ab8c18a3c4 100644 --- a/packages/astro/test/server/middleware.test.ts +++ b/packages/astro/test/server/middleware.test.ts @@ -47,7 +47,7 @@ describe('sentryMiddleware', () => { source: 'route', }, name: 'GET /users/[id]/details', - op: 'http.server.get', + op: 'http.server', origin: 'auto.http.astro', status: 'ok', },