Change naming for networkDetailExcludeUrls to networkDetailDenyUrls

Author: ziyad-elabid-nw

packages/replay/src/coreHandlers/handleNetworkBreadcrumbs.ts

@@ -33,7 +33,7 @@ export function handleNetworkBreadcrumbs(replay: ReplayContainer): void {
 
     const {
       networkDetailAllowUrls,
-      networkDetailExcludeUrls,
+      networkDetailDenyUrls,
       networkCaptureBodies,
       networkRequestHeaders,
       networkResponseHeaders,
@@ -43,7 +43,7 @@ export function handleNetworkBreadcrumbs(replay: ReplayContainer): void {
       replay,
       textEncoder,
       networkDetailAllowUrls,
-      networkDetailExcludeUrls,
+      networkDetailDenyUrls,
       networkCaptureBodies,
       networkRequestHeaders,
       networkResponseHeaders,

packages/replay/src/coreHandlers/util/fetchUtils.ts

@@ -86,7 +86,7 @@ async function _prepareFetchData(
   } = breadcrumb.data;
 
   const captureDetails =
-    urlMatches(url, options.networkDetailAllowUrls) && !urlMatches(url, options.networkDetailExcludeUrls);
+    urlMatches(url, options.networkDetailAllowUrls) && !urlMatches(url, options.networkDetailDenyUrls);
 
   const request = captureDetails
     ? _getRequestInfo(options, hint.input, requestBodySize)

packages/replay/src/coreHandlers/util/xhrUtils.ts

@@ -78,7 +78,7 @@ function _prepareXhrData(
     return null;
   }
 
-  if (!urlMatches(url, options.networkDetailAllowUrls) || urlMatches(url, options.networkDetailExcludeUrls)) {
+  if (!urlMatches(url, options.networkDetailAllowUrls) || urlMatches(url, options.networkDetailDenyUrls)) {
     const request = buildSkippedNetworkRequestOrResponse(requestBodySize);
     const response = buildSkippedNetworkRequestOrResponse(responseBodySize);
     return {

packages/replay/src/integration.ts

@@ -67,7 +67,7 @@ export class Replay implements Integration {
     slowClickIgnoreSelectors = [],
 
     networkDetailAllowUrls = [],
-    networkDetailExcludeUrls = [],
+    networkDetailDenyUrls = [],
     networkCaptureBodies = true,
     networkRequestHeaders = [],
     networkResponseHeaders = [],
@@ -139,7 +139,7 @@ export class Replay implements Integration {
       slowClickTimeout,
       slowClickIgnoreSelectors,
       networkDetailAllowUrls,
-      networkDetailExcludeUrls,
+      networkDetailDenyUrls,
       networkCaptureBodies,
       networkRequestHeaders: _getMergedNetworkHeaders(networkRequestHeaders),
       networkResponseHeaders: _getMergedNetworkHeaders(networkResponseHeaders),

packages/replay/src/types/replay.ts

@@ -71,31 +71,31 @@ export interface ReplayNetworkOptions {
   networkDetailAllowUrls: (string | RegExp)[];
 
   /**
-   * Exclude request/response details for XHR/Fetch requests that match the given URLs.
+   * Deny request/response details for XHR/Fetch requests that match the given URLs.
    * The URLs can be strings or regular expressions.
-   * When provided a string, we will exclude any URL that contains the given string.
+   * When provided a string, we will deny any URL that contains the given string.
    * You can use a Regex to handle exact matches or more complex matching.
    * URLs matching these patterns will not have bodies & additional headers captured.
    */
-  networkDetailExcludeUrls: (string | RegExp)[];
+  networkDetailDenyUrls: (string | RegExp)[];
 
   /**
    * If request & response bodies should be captured.
-   * Only applies to URLs matched by `networkDetailAllowUrls` and not matched by `networkDetailExcludeUrls`.
+   * Only applies to URLs matched by `networkDetailAllowUrls` and not matched by `networkDetailDenyUrls`.
    * Defaults to true.
    */
   networkCaptureBodies: boolean;
 
   /**
    * Capture the following request headers, in addition to the default ones.
-   * Only applies to URLs matched by `networkDetailAllowUrls` and not matched by `networkDetailExcludeUrls`.
+   * Only applies to URLs matched by `networkDetailAllowUrls` and not matched by `networkDetailDenyUrls`.
    * Any headers defined here will be captured in addition to the default headers.
    */
   networkRequestHeaders: string[];
 
   /**
    * Capture the following response headers, in addition to the default ones.
-   * Only applies to URLs matched by `networkDetailAllowUrls` and not matched by `networkDetailExcludeUrls`.
+   * Only applies to URLs matched by `networkDetailAllowUrls` and not matched by `networkDetailDenyUrls`.
    * Any headers defined here will be captured in addition to the default headers.
    */
   networkResponseHeaders: string[];

packages/replay/test/unit/coreHandlers/handleNetworkBreadcrumbs.test.ts

@@ -63,7 +63,7 @@ describe('Unit | coreHandlers | handleNetworkBreadcrumbs', () => {
         textEncoder: new TextEncoder(),
         replay: setupReplayContainer(),
         networkDetailAllowUrls: ['https://example.com'],
-        networkDetailExcludeUrls: ['http://localhost:8080'],
+        networkDetailDenyUrls: ['http://localhost:8080'],
         networkCaptureBodies: false,
         networkRequestHeaders: ['content-type', 'accept', 'x-custom-header'],
         networkResponseHeaders: ['content-type', 'accept', 'x-custom-header'],
@@ -1390,8 +1390,8 @@ other-header: test`;
       ['exact regex match', 'http://example.com/exact'],
       ['partial regex match', 'http://example.com/partial/string'],
     ])('matching URL %s', (_label, url) => {
-      it('correctly excludes URL for fetch request', async () => {
-        options.networkDetailExcludeUrls = [
+      it('correctly deny URL for fetch request', async () => {
+        options.networkDetailDenyUrls = [
           'https://example.com/foo',
           'com/bar',
           /^http:\/\/example.com\/exact$/,
@@ -1465,8 +1465,8 @@ other-header: test`;
         ]);
       });
 
-      it('correctly excludes URL for xhr request', async () => {
-        options.networkDetailExcludeUrls = [
+      it('correctly deny URL for xhr request', async () => {
+        options.networkDetailDenyUrls = [
           'https://example.com/foo',
           'com/bar',
           /^http:\/\/example.com\/exact$/,

packages/replay/test/utils/setupReplayContainer.ts

@@ -12,7 +12,7 @@ const DEFAULT_OPTIONS = {
   useCompression: false,
   blockAllMedia: true,
   networkDetailAllowUrls: [],
-  networkDetailExcludeUrls: [],
+  networkDetailDenyUrls: [],
   networkCaptureBodies: true,
   networkRequestHeaders: [],
   networkResponseHeaders: [],