From fecc71edeca6926d3bd28fea159b53032a56f70e Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Tue, 6 Feb 2024 10:55:56 +0100 Subject: [PATCH] build(ci): Ensure we run E2E tests when profiling node is skipped --- .github/workflows/build.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b8afc90dbde9..226fc3b72a6d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -952,7 +952,13 @@ jobs: job_e2e_prepare: name: Prepare E2E tests - if: + # We want to run this if: + # - The build job was successful, not skipped + # - AND if the profiling node bindings were either successful or skipped + # AND if this is not a PR from a fork or dependabot + if: | + always() && needs.job_build.result == 'success' && + (needs.job_compile_bindings_profiling_node.result == 'success' || needs.job_compile_bindings_profiling_node.result == 'skipped') && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' needs: [job_get_metadata, job_build, job_compile_bindings_profiling_node] @@ -1014,7 +1020,9 @@ jobs: name: E2E ${{ matrix.label || matrix.test-application }} Test # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks # Dependabot PRs sadly also don't have access to secrets, so we skip them as well + # We need to add the `always()` check here because the previous step has this as well :( if: + always() && needs.job_e2e_prepare.result == 'success' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' needs: [job_get_metadata, job_build, job_e2e_prepare]