New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoreErrors to take function instead of list of regexp/strings #1059

Closed
kamilogorek opened this Issue Sep 27, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@kamilogorek
Member

kamilogorek commented Sep 27, 2017

ref: #1057

@jaydp17

This comment has been minimized.

Show comment
Hide comment
@jaydp17

jaydp17 Oct 4, 2017

There are 2 ways we can do this.

  1. Allow globalOptions.ignoreErrors to take regex/string as well as functions
  2. Add something like globalOptions.shouldIgnoreError which takes a function and returns a boolean

I'd prefer the 1st option but would like to know your opinion.

jaydp17 commented Oct 4, 2017

There are 2 ways we can do this.

  1. Allow globalOptions.ignoreErrors to take regex/string as well as functions
  2. Add something like globalOptions.shouldIgnoreError which takes a function and returns a boolean

I'd prefer the 1st option but would like to know your opinion.

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Oct 4, 2017

Member

Agree that 1st option is more optimal. Please keep this comment in mind though #1057 (comment)

Member

kamilogorek commented Oct 4, 2017

Agree that 1st option is more optimal. Please keep this comment in mind though #1057 (comment)

@HeroProtagonist

This comment has been minimized.

Show comment
Hide comment
@HeroProtagonist

HeroProtagonist Oct 6, 2017

Contributor

Hi,

Happy Hacktober! I will take a stab at this. PR to come in the next day or two.

Cheers!

Contributor

HeroProtagonist commented Oct 6, 2017

Hi,

Happy Hacktober! I will take a stab at this. PR to come in the next day or two.

Cheers!

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Oct 6, 2017

Member

Hey @HeroProtagonist! This issue is already in-progress – #1072 :)

However, we more things to choose from:

Feel free to ask if you need any help :)

Member

kamilogorek commented Oct 6, 2017

Hey @HeroProtagonist! This issue is already in-progress – #1072 :)

However, we more things to choose from:

Feel free to ask if you need any help :)

@HeroProtagonist

This comment has been minimized.

Show comment
Hide comment
@HeroProtagonist

HeroProtagonist Oct 8, 2017

Contributor

@kamilogorek , Got it! I made a PR for #774 #1080. Hopefully it's good 🤞

Contributor

HeroProtagonist commented Oct 8, 2017

@kamilogorek , Got it! I made a PR for #774 #1080. Hopefully it's good 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment