Skip to content

Conversation

@kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek requested a review from HazAT April 23, 2018 11:46
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Still, want to have @mitsuhiko blessing since we just talked about this in the morning and he meant it's not a good idea 🙈

@HazAT HazAT requested a review from mitsuhiko April 23, 2018 12:56
Copy link
Contributor

@mitsuhiko mitsuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not reorder breadcrumbs but figure out why they are incorrectly sorted in the first place.

@kamilogorek
Copy link
Contributor Author

@mitsuhiko it's because you can pass the timestamp as one of the attributes to createBreadcrumb - https://github.com/getsentry/raven-js/blob/master/src/raven.js#L635-L640

Would you rather just override user's data by swapping the order of a merge?

var crumb = objectMerge(obj, {
  timestamp: now() / 1000
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants