From 7d141e6c79a3858b6d83392a1335bb2910e48b3d Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 16 Sep 2025 12:28:25 +0200 Subject: [PATCH 1/2] test(sveltekit): Pin kit versions and fix failing tests --- .../test-applications/sveltekit-2-kit-tracing/package.json | 2 +- .../test-applications/sveltekit-2-svelte-5/package.json | 2 +- .../sveltekit-2-svelte-5/tests/performance.test.ts | 2 +- .../e2e-tests/test-applications/sveltekit-2/package.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-kit-tracing/package.json b/dev-packages/e2e-tests/test-applications/sveltekit-2-kit-tracing/package.json index 03e5441733da..2b6184b8cb28 100644 --- a/dev-packages/e2e-tests/test-applications/sveltekit-2-kit-tracing/package.json +++ b/dev-packages/e2e-tests/test-applications/sveltekit-2-kit-tracing/package.json @@ -22,7 +22,7 @@ "@playwright/test": "~1.53.2", "@sentry-internal/test-utils": "link:../../../test-utils", "@sveltejs/adapter-node": "^5.3.1", - "@sveltejs/kit": "^2.31.0", + "@sveltejs/kit": "2.31.0", "@sveltejs/vite-plugin-svelte": "^6.1.3", "svelte": "^5.38.3", "svelte-check": "^4.3.1", diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/package.json b/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/package.json index 689934c1011f..3c5dcfd8f279 100644 --- a/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/package.json +++ b/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/package.json @@ -22,7 +22,7 @@ "@playwright/test": "~1.53.2", "@sentry-internal/test-utils": "link:../../../test-utils", "@sveltejs/adapter-auto": "^3.0.0", - "@sveltejs/kit": "^2.21.3", + "@sveltejs/kit": "2.41.0", "@sveltejs/vite-plugin-svelte": "^3.0.0", "svelte": "^5.0.0-next.115", "svelte-check": "^3.6.0", diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts index 95855d8f8e81..6c33d7555e1a 100644 --- a/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts +++ b/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts @@ -316,7 +316,7 @@ test.describe('performance events', () => { 'sentry.origin': 'auto.navigation.sveltekit', 'sentry.op': 'navigation', 'sentry.source': 'route', - 'sentry.sveltekit.navigation.type': 'goto', + 'sentry.sveltekit.navigation.type': 'link', 'sentry.sveltekit.navigation.from': '/', 'sentry.sveltekit.navigation.to': '/redirect2', 'sentry.sample_rate': 1, diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2/package.json b/dev-packages/e2e-tests/test-applications/sveltekit-2/package.json index 03b4b1dad959..1f73b47bc10b 100644 --- a/dev-packages/e2e-tests/test-applications/sveltekit-2/package.json +++ b/dev-packages/e2e-tests/test-applications/sveltekit-2/package.json @@ -22,7 +22,7 @@ "@sentry-internal/test-utils": "link:../../../test-utils", "@sveltejs/adapter-auto": "^3.0.0", "@sveltejs/adapter-node": "^2.0.0", - "@sveltejs/kit": "^2.21.3", + "@sveltejs/kit": "2.21.3", "@sveltejs/vite-plugin-svelte": "^3.0.0", "svelte": "^4.2.8", "svelte-check": "^3.6.0", From ca506a44cbbaf36729a35008c0d12f93ac0c51b4 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 16 Sep 2025 12:42:25 +0200 Subject: [PATCH 2/2] fix for real --- .../sveltekit-2-svelte-5/tests/performance.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts index 6c33d7555e1a..6a29276f4dc8 100644 --- a/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts +++ b/dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts @@ -337,7 +337,7 @@ test.describe('performance events', () => { 'sentry.origin': 'auto.ui.sveltekit', 'sentry.sveltekit.navigation.from': '/', 'sentry.sveltekit.navigation.to': '/redirect2', - 'sentry.sveltekit.navigation.type': 'goto', + 'sentry.sveltekit.navigation.type': 'link', }, }); @@ -353,7 +353,7 @@ test.describe('performance events', () => { 'sentry.origin': 'auto.navigation.sveltekit', 'sentry.op': 'navigation', 'sentry.source': 'route', - 'sentry.sveltekit.navigation.type': 'goto', + 'sentry.sveltekit.navigation.type': 'link', 'sentry.sveltekit.navigation.from': '/', 'sentry.sveltekit.navigation.to': '/users/[id]', 'sentry.sample_rate': 1, @@ -374,7 +374,7 @@ test.describe('performance events', () => { 'sentry.origin': 'auto.ui.sveltekit', 'sentry.sveltekit.navigation.from': '/', 'sentry.sveltekit.navigation.to': '/users/[id]', - 'sentry.sveltekit.navigation.type': 'goto', + 'sentry.sveltekit.navigation.type': 'link', }, }); });