Skip to content

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Nov 5, 2025

Ref / Resolves: #18089

hoist-non-react-statics package we depend on is not ESM compatible, and causing issues for users on Cloudflare environments. As this package has not been updated in 5 years, and our use has not changed for long time, I think we can just inline this to make it compatible, and save users from explicitly externalizing this package.

@onurtemizkan onurtemizkan force-pushed the onur/inline-hoist-non-react-statics branch from b28862f to 4cfaf34 Compare November 5, 2025 15:16
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,821 - 8,762 +1%
GET With Sentry 1,378 16% 1,394 -1%
GET With Sentry (error only) 6,228 71% 6,136 +1%
POST Baseline 1,218 - 1,200 +2%
POST With Sentry 507 42% 542 -6%
POST With Sentry (error only) 1,061 87% 1,062 -0%
MYSQL Baseline 3,381 - 3,361 +1%
MYSQL With Sentry 478 14% 476 +0%
MYSQL With Sentry (error only) 2,734 81% 2,740 -0%

View base workflow run

@onurtemizkan onurtemizkan force-pushed the onur/inline-hoist-non-react-statics branch 2 times, most recently from 8d6bde6 to 76f668a Compare November 10, 2025 21:07
@onurtemizkan onurtemizkan force-pushed the onur/inline-hoist-non-react-statics branch from 76f668a to 8d0a14e Compare November 11, 2025 09:59
@onurtemizkan onurtemizkan marked this pull request as ready for review November 11, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hydrogen 2025.7.0, entry.server.tsx doesn't work, (ReferenceError: require is not defined)

2 participants