fix(core): continueTrace doesn't propagate given trace ID if active span exists #18328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…already an active span
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
nicohrubec
changed the title
3 tasks
Lms24
reviewed
Nov 26, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice work, thanks! (and thanks for fixing that Sveltekit test!)
| // simulating a nested load call: | ||
| await sentryHandle()({ | ||
| event: mockEvent({ route: { id: 'api/users/details/[id]', isSubRequest: true } }), | ||
| event: mockEvent({ route: { id: 'api/users/details/[id]' }, isSubRequest: true }), |
Member
There was a problem hiding this comment.
good catch, and very interesting that this passed beforehand 🤔 👀
Member
Author
There was a problem hiding this comment.
yeah it is! didn't investigate further though
| }); | ||
| }); | ||
|
|
||
| it('works inside an active span', () => { |
Member
There was a problem hiding this comment.
l: let's find a slightly more descriptive description. Feel free to go with something else but suggestion:
Suggested change
| it('works inside an active span', () => { | |
| it('updates the propagation context when called inside an active span', () => { |
Comment on lines
+2056
to
+2057
| }); | ||
| }); |
Member
There was a problem hiding this comment.
m: Let's also add a second test that shows that when you now start another span within the continueTrace callback, it has the traceId and parentSpanId that's passed to continueTrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During investigation of this issue, we discovered that
continueTracedoes not propagate the given trace ID if it is called from within an already active span (in this instance this happened because of the already active span started by the cloudflare auto-instrumentation.Solution: This PR resolves this behavior by setting the currently active span to undefined when forking the propagation context in
continueTrace.Tests:
@sentry/sveltekitunit tests started to fail. Not sure why this was triggered by this change, but I fixed it by setting theisSubRequestproperty on the event instead of the route, which seems correct to me.@sentry/corethat callscontinueTraceinside an active span and checks that the trace id is now propagated as we would expect.