Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop initial frame for production react errors #2728

Merged
merged 1 commit into from Jul 8, 2020

Conversation

@kamilogorek
Copy link
Member

@kamilogorek kamilogorek commented Jul 8, 2020

Because framesToPop is not used in RN or React anymore.

@kamilogorek kamilogorek requested review from HazAT and AbhiPrasad Jul 8, 2020
@getsentry-bot
Copy link

@getsentry-bot getsentry-bot commented Jul 8, 2020

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.1982 kB) (ES6: 16.3027 kB)

📖 TSLint passed

Generated by 🚫 dangerJS against 0618071

if (typeof ex.framesToPop === 'number') {
popSize = ex.framesToPop;
} else if (reactMinifiedRegexp.test(ex.message)) {
popSize = 1;

This comment has been minimized.

@AbhiPrasad

AbhiPrasad Jul 8, 2020
Contributor

Are we sure this will always be 1?

@kamilogorek kamilogorek merged commit b1f0c6a into master Jul 8, 2020
2 checks passed
2 checks passed
Danger Found some issues. Don't worry, everything is fixable.
Details
Travis CI - Pull Request Build Passed
Details
@kamilogorek kamilogorek deleted the handle-react-stack branch Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.