From f474c74fa917efab92bc900b93d071dd3977c652 Mon Sep 17 00:00:00 2001 From: Primoz Hadalin Date: Mon, 14 Sep 2020 16:27:33 +0200 Subject: [PATCH 1/2] fix: Typo --- packages/integrations/src/vue.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/integrations/src/vue.ts b/packages/integrations/src/vue.ts index dd0250224853..bdb165d42875 100644 --- a/packages/integrations/src/vue.ts +++ b/packages/integrations/src/vue.ts @@ -313,7 +313,7 @@ export class Vue implements Integration { } }; - // Each compomnent has it's own scope, so all activities are only related to one of them + // Each component has it's own scope, so all activities are only related to one of them this._options.tracingOptions.hooks.forEach(operation => { // Retrieve corresponding hooks from Vue lifecycle. // eg. mount => ['beforeMount', 'mounted'] From acfbce7d095da362676858a59765e030ba4bb50f Mon Sep 17 00:00:00 2001 From: Primoz Hadalin Date: Mon, 14 Sep 2020 14:35:21 +0200 Subject: [PATCH 2/2] fix: Make Vue tracing options optional --- packages/integrations/src/vue.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/integrations/src/vue.ts b/packages/integrations/src/vue.ts index bdb165d42875..49490f74145e 100644 --- a/packages/integrations/src/vue.ts +++ b/packages/integrations/src/vue.ts @@ -151,7 +151,9 @@ export class Vue implements Integration { /** * @inheritDoc */ - public constructor(options: Partial) { + public constructor( + options: Partial & { tracingOptions: Partial }>, + ) { this._options = { // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access Vue: getGlobalObject().Vue,