Skip to content

chore(nextjs): Cosmetic changes ahead of API route fix #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 8, 2021
Merged

chore(nextjs): Cosmetic changes ahead of API route fix #3784

merged 16 commits into from
Jul 8, 2021

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jul 7, 2021 •
edited
Loading

Nothing substantive here - just a bunch of changes pulled out of an upcoming PR fixing API route monitoring in nextjs, to make that one easier to review.

Major themes:

  • Standardize naming
  • Split current and new values into separate variables
  • Remove old code
    • Check for entry point existence (moot given our minimum supported nextjs version)
    • Unnecessary stuff which came along when tracing code was copied from instrumentServer.js

@lobsterkatie lobsterkatie requested a review from kamilogorek as a code owner July 7, 2021 22:50
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.43 KB (0%)
@sentry/browser - Webpack 22.45 KB (0%)
@sentry/react - Webpack 22.49 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.93 KB (0%)

@lobsterkatie lobsterkatie mentioned this pull request Jul 8, 2021
Merged
AbhiPrasad
AbhiPrasad reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

AbhiPrasad
AbhiPrasad approved these changes Jul 8, 2021
View reviewed changes
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-pre-inject-init-in-api-routes-clean-up branch from d8f4a82 to 7362042 Compare July 8, 2021 18:00
@lobsterkatie lobsterkatie merged commit 484aad5 into master Jul 8, 2021
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-pre-inject-init-in-api-routes-clean-up branch July 8, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

+1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lobsterkatie @kamilogorek @AbhiPrasad