From f7edc35b5e5f974c8c9b07d1a17dea2618a40aac Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Mon, 2 Aug 2021 11:41:34 -0700 Subject: [PATCH 1/2] rename handlers.ts --- packages/nextjs/src/index.server.ts | 2 +- packages/nextjs/src/utils/{handlers.ts => withSentry.ts} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename packages/nextjs/src/utils/{handlers.ts => withSentry.ts} (100%) diff --git a/packages/nextjs/src/index.server.ts b/packages/nextjs/src/index.server.ts index 84eec5c6469f..b24891c48378 100644 --- a/packages/nextjs/src/index.server.ts +++ b/packages/nextjs/src/index.server.ts @@ -54,7 +54,7 @@ function addServerIntegrations(options: NextjsOptions): void { } export { withSentryConfig } from './config'; -export { withSentry } from './utils/handlers'; +export { withSentry } from './utils/withSentry'; // wrap various server methods to enable error monitoring and tracing instrumentServer(); diff --git a/packages/nextjs/src/utils/handlers.ts b/packages/nextjs/src/utils/withSentry.ts similarity index 100% rename from packages/nextjs/src/utils/handlers.ts rename to packages/nextjs/src/utils/withSentry.ts From ff3817fbc8eb312c6b8967f8f1853fa422b670c9 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Mon, 2 Aug 2021 18:38:25 -0700 Subject: [PATCH 2/2] remove unnecessary TODO --- packages/nextjs/src/utils/withSentry.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/nextjs/src/utils/withSentry.ts b/packages/nextjs/src/utils/withSentry.ts index 8a134e89600c..dbccfceb1724 100644 --- a/packages/nextjs/src/utils/withSentry.ts +++ b/packages/nextjs/src/utils/withSentry.ts @@ -98,8 +98,6 @@ type WrappedResponseEndMethod = AugmentedResponse['end']; function wrapEndMethod(origEnd: ResponseEndMethod): WrappedResponseEndMethod { return async function newEnd(this: AugmentedResponse, ...args: unknown[]) { - // TODO: if the handler errored, it will have popped us out of the domain, so all of our scope data will be missing - const transaction = this.__sentryTransaction; if (transaction) {