From 2341759ee01406c94618026250eaf7affcd30a89 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Fri, 17 Mar 2023 13:33:38 -0400 Subject: [PATCH 1/3] chore(replay): Upgrade `rrweb` and `rrweb-player` See [CHANGELOG](https://github.com/getsentry/rrweb/blob/cd51c854464e803405282a1affc7fc580d2acd94/CHANGELOG.md#11060) --- packages/replay/package.json | 4 ++-- yarn.lock | 18 +++++++++--------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/replay/package.json b/packages/replay/package.json index 37b2b2233cbc..4eecc0987010 100644 --- a/packages/replay/package.json +++ b/packages/replay/package.json @@ -45,8 +45,8 @@ "devDependencies": { "@babel/core": "^7.17.5", "@sentry-internal/replay-worker": "7.43.0", - "@sentry-internal/rrweb": "1.105.0", - "@sentry-internal/rrweb-snapshot": "1.105.0", + "@sentry-internal/rrweb": "1.106.0", + "@sentry-internal/rrweb-snapshot": "1.106.0", "jsdom-worker": "^0.2.1", "tslib": "^1.9.3" }, diff --git a/yarn.lock b/yarn.lock index 554a09d17be1..9e05ec7d4107 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4032,17 +4032,17 @@ semver "7.3.2" semver-intersect "1.4.0" -"@sentry-internal/rrweb-snapshot@1.105.0": - version "1.105.0" - resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-1.105.0.tgz#b95d056e3602ab075049b31354942051137f3de2" - integrity sha512-UsrCVB5PVKTd3nXidUQSFQPjMHi2p5RzcujdBVuZfOJmRAqkHW6fN3CM4H6vJh0L5bgs+O/MFTNSv+iiAyVrBQ== +"@sentry-internal/rrweb-snapshot@1.106.0": + version "1.106.0" + resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-1.106.0.tgz#24714d4005a918855eeb09d4deda457198f77caf" + integrity sha512-jLX6uGAW8StwPlQOScLhERVa6VOPmbQRFdhTx70Flkt0ocxg2vBJSdaI4Efu3jU0mtA0gHR01LB5xd1ODMRXow== -"@sentry-internal/rrweb@1.105.0": - version "1.105.0" - resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-1.105.0.tgz#c4238692753ed910d0fc23887361cc4d5d5112ab" - integrity sha512-RwJiQXaYzvLhqkAJtvwxu6WuO3OnedTpWtfdJX73kYujleSzoIBRNUXBs03Ir9E48UN5gzKu/eRG76QdH+e8Ow== +"@sentry-internal/rrweb@1.106.0": + version "1.106.0" + resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-1.106.0.tgz#251026e42cf142119eed0616808a279099aa0573" + integrity sha512-/YtV8EoWmMoTE592aVdrgGH5EBiCILdKOt228pM+juGaxRqFxsX26UIeTJG7fihSweUz6NLbKXZjS0+cFYmhrQ== dependencies: - "@sentry-internal/rrweb-snapshot" "1.105.0" + "@sentry-internal/rrweb-snapshot" "1.106.0" "@types/css-font-loading-module" "0.0.7" "@xstate/fsm" "^1.4.0" base64-arraybuffer "^1.0.1" From 0c88b85e8a915180900edf28a964d3e48df84aa7 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Fri, 17 Mar 2023 13:55:14 -0400 Subject: [PATCH 2/3] update test to account for bug fix --- .../suites/replay/customEvents/test.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/browser-integration-tests/suites/replay/customEvents/test.ts b/packages/browser-integration-tests/suites/replay/customEvents/test.ts index e64a76badea6..7d782b24e85c 100644 --- a/packages/browser-integration-tests/suites/replay/customEvents/test.ts +++ b/packages/browser-integration-tests/suites/replay/customEvents/test.ts @@ -163,10 +163,7 @@ sentryTest( nodeId: expect.any(Number), node: { attributes: { - // TODO(rrweb): This is a bug in our rrweb fork! - // This attribute should be unmasked. - // 'aria-label': 'Unmasked label', - 'aria-label': '******** *****', + 'aria-label': 'Unmasked label', class: 'sentry-unmask', }, id: expect.any(Number), From 3613949220accd359cfc45c60b07b702e77d715a Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 20 Mar 2023 09:13:34 +0100 Subject: [PATCH 3/3] add changelog --- CHANGELOG.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49a101e7a76f..6829ddefa579 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,15 @@ - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott +**Replay `rrweb` changes:** + +`@sentry-internal/rrweb` was updated from 1.105.0 to 1.106.0: + +- feat: Ensure password inputs are always masked ([#78](https://github.com/getsentry/rrweb/pull/78)) +- fix: Ensure text masking for updated attributes works ([#83](https://github.com/getsentry/rrweb/pull/83)) +- fix: Ensure unmaskTextSelector is used for masked attributes ([#81](https://github.com/getsentry/rrweb/pull/81)) +- fix: Mask