Skip to content

fix(browser): Adjust transportOptions to support offline transport options #7775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 1 commit into from
Apr 6, 2023
Merged

fix(browser): Adjust transportOptions to support offline transport options #7775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/browser/src/transports/offline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export function pop(store: Store): Promise<Uint8Array | string | undefined> {
});
}

interface BrowserOfflineTransportOptions extends OfflineTransportOptions {
export interface BrowserOfflineTransportOptions extends OfflineTransportOptions {
/**
* Name of indexedDb database to store envelopes in
* Default: 'sentry-offline'
Expand Down
6 changes: 5 additions & 1 deletion packages/browser/src/transports/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import type { BaseTransportOptions } from '@sentry/types';

export interface BrowserTransportOptions extends BaseTransportOptions {
import type { BrowserOfflineTransportOptions } from './offline';

type BaseTransportAndOfflineTransportOptions = BaseTransportOptions & BrowserOfflineTransportOptions;

export interface BrowserTransportOptions extends BaseTransportAndOfflineTransportOptions {
/** Fetch API init parameters. Used by the FetchTransport */
fetchOptions?: RequestInit;
/** Custom headers for the transport. Used by the XHRTransport and FetchTransport */
Expand Down