From 91d561e8d166f9116531387f42ba7a5a3a145a3a Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Sun, 14 May 2023 19:56:48 +0100 Subject: [PATCH 1/3] reproduce with test --- packages/tracing-internal/test/browser/request.test.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/tracing-internal/test/browser/request.test.ts b/packages/tracing-internal/test/browser/request.test.ts index 9c5567e3fdcd..62b8178ed953 100644 --- a/packages/tracing-internal/test/browser/request.test.ts +++ b/packages/tracing-internal/test/browser/request.test.ts @@ -400,12 +400,16 @@ describe('shouldAttachHeaders', () => { 'http://localhost:3000/test', 'http://somewhere.com/test/localhost/123', 'http://somewhere.com/test?url=localhost:3000&test=123', + '//localhost:3000/test', ])('return `true` for urls matching defaults (%s)', url => { expect(shouldAttachHeaders(url, undefined)).toBe(true); }); - it.each(['notmydoman/api/test', 'example.com'])('return `false` for urls not matching defaults (%s)', url => { - expect(shouldAttachHeaders(url, undefined)).toBe(false); - }); + it.each(['notmydoman/api/test', 'example.com', '//example.com'])( + 'return `false` for urls not matching defaults (%s)', + url => { + expect(shouldAttachHeaders(url, undefined)).toBe(false); + }, + ); }); }); From 6d50bb592899c341785ac94083af4232066e8068 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Sun, 14 May 2023 19:59:44 +0100 Subject: [PATCH 2/3] adjust default same origin regex --- packages/tracing-internal/src/browser/request.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tracing-internal/src/browser/request.ts b/packages/tracing-internal/src/browser/request.ts index fc3fd6d74fc0..777c263aa4ef 100644 --- a/packages/tracing-internal/src/browser/request.ts +++ b/packages/tracing-internal/src/browser/request.ts @@ -10,7 +10,7 @@ import { stringMatchesSomePattern, } from '@sentry/utils'; -export const DEFAULT_TRACE_PROPAGATION_TARGETS = ['localhost', /^\//]; +export const DEFAULT_TRACE_PROPAGATION_TARGETS = ['localhost', /^\/[^/]/]; /** Options for Request Instrumentation */ export interface RequestInstrumentationOptions { From da906d5959d7af5587bc618be370483913590850 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 15 May 2023 11:57:47 +0200 Subject: [PATCH 3/3] adjust regex to negative lookahead --- packages/tracing-internal/src/browser/request.ts | 2 +- packages/tracing-internal/test/browser/request.test.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/tracing-internal/src/browser/request.ts b/packages/tracing-internal/src/browser/request.ts index 777c263aa4ef..94587c0380b1 100644 --- a/packages/tracing-internal/src/browser/request.ts +++ b/packages/tracing-internal/src/browser/request.ts @@ -10,7 +10,7 @@ import { stringMatchesSomePattern, } from '@sentry/utils'; -export const DEFAULT_TRACE_PROPAGATION_TARGETS = ['localhost', /^\/[^/]/]; +export const DEFAULT_TRACE_PROPAGATION_TARGETS = ['localhost', /^\/(?!\/)/]; /** Options for Request Instrumentation */ export interface RequestInstrumentationOptions { diff --git a/packages/tracing-internal/test/browser/request.test.ts b/packages/tracing-internal/test/browser/request.test.ts index 62b8178ed953..c677818752cc 100644 --- a/packages/tracing-internal/test/browser/request.test.ts +++ b/packages/tracing-internal/test/browser/request.test.ts @@ -401,6 +401,7 @@ describe('shouldAttachHeaders', () => { 'http://somewhere.com/test/localhost/123', 'http://somewhere.com/test?url=localhost:3000&test=123', '//localhost:3000/test', + '/', ])('return `true` for urls matching defaults (%s)', url => { expect(shouldAttachHeaders(url, undefined)).toBe(true); });