Skip to content

Conversation

@benvinegar
Copy link
Contributor

Refs #705

cc @graingert

@benvinegar
Copy link
Contributor Author

cc @mattrobenolt – does what @graingert and I've written make sense?

@mattrobenolt
Copy link
Contributor

It may be worth mentioning that they can also set their own header entirely. For example, basic auth could be leveraged here if they set the header to Authorization and set the key to Basic .....

@benvinegar
Copy link
Contributor Author

benvinegar commented Mar 23, 2017

For example, basic auth could be leveraged here if they set the header to Authorization and set the key to Basic .....

I don't think we ever merged the Sentry PR that lets you do that (which might also be a @graingert joint).

@mattrobenolt
Copy link
Contributor

Yeah, he threw up the original PR, and I carried it through with getsentry/sentry#4630

It made it into 8.13 release.

@benvinegar
Copy link
Contributor Author

@mattrobenolt – ah, I see, I misread settings.

I made an update. That work?

@benvinegar benvinegar merged commit 069e7d0 into master Mar 23, 2017
@benvinegar benvinegar deleted the source-map-secret branch March 23, 2017 06:11
@graingert
Copy link
Contributor

graingert commented Mar 23, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants