Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually forward any other view engine calls #395

Merged
merged 2 commits into from Oct 6, 2020

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Oct 1, 2020

We "decorate" the view engine but we are not actually decorating it in the sense we forward unchanged behaviour to the original proxy (still called a decorator?).

This change will do that so any underlying engines will still work even if they implement custom methods (for example Livewire and even Laravel core does this).

Fixes #394.

@stayallive stayallive requested a review from HazAT Oct 1, 2020
HazAT
HazAT approved these changes Oct 6, 2020
@stayallive stayallive merged commit be93e34 into master Oct 6, 2020
2 checks passed
@stayallive stayallive deleted the feature/actually-decorate-the-view-engine branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants