Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env data from HTTP #326

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Projects
None yet
1 participant
@dcramer
Copy link
Member

commented Jul 22, 2016

This contains potentially sensitive information, and as we move forward with Sentry it no longer logically makes sense for it to exist as part of this. If users want it they can use extra_context.

@getsentry/php


This change is Reviewable

Remove env data from HTTP
This contains potentially sensitive information, and as we move forward with Sentry it no longer logically makes sense for it to exist as part of this. If users want it they can use ``extra_context``.

@getsentry/php

@dcramer dcramer force-pushed the fix/remove-env branch from ba920bb to 35245bc Jul 22, 2016

@dcramer

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2016

This will likely be contentious with the community, but to avoid future discussion we're taking a hard stance on this as it's too easy to leak extremely sensitive data. If we want to re-introduce any of this I'd be ok with PRs that do an allow-list of variables.

@dcramer dcramer merged commit dcc7b15 into master Jul 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dcramer dcramer deleted the fix/remove-env branch Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.