Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cleanupPendingRequests public #867

Closed
wants to merge 1 commit into from
Closed

Conversation

ruudk
Copy link

@ruudk ruudk commented Aug 14, 2019

This allows for cleaning up pending requests in a long running process (queue consumer).

I want to create a LongRunning Cleaner that automatically calls this method when the cleaner is executed. For example after the execution of a RabbitMQ message in a consumer.

This allows for cleaning up pending requests in a long running process (queue consumer).
@ste93cry
Copy link
Collaborator

Thank you for the contribution, this issue is going to be solved with the implementation of a public flush method on the Client class and subsequent refactoring of the transports to align them with the Unified API specs. The update is going to be merged as part of 2.2 that will came hopefully soon. Making this method public now means that we cannot revert this change anymore because we would break BC. Right now the suggested workaround is to create your own transport and implement the logic you need to flush the events on-demand. Other solutions have been posted in #811. Closing this, you can check the referenced issue for updates

@ruudk
Copy link
Author

ruudk commented Aug 14, 2019

@ste93cry Thanks for the fast reply. I should have searched for the issue first. Glad to hear that you are working on this 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants