Add HipChat (Connect) plugin #7
Conversation
This still needs to manage asset loading. Right now it can generate the .js file, but theres nothing to do it automatically (e.g. as part of setup.py install), and there's nothing to actually load the .js in Sentry itself. |
Of note, I'm going to test this against master, and if it works we can probably get the core of this in, and do a follow up PR which finishes the React transition (as it won't even be used in master right now). |
Seems to still work fine without the React changes |
Also I fixed like 10 |
FYI the only changes here are:
|
Reviewed 31 of 38 files at r1, 1 of 2 files at r2, 9 of 9 files at r3. webpack.config.js, line 50 [r1] (raw file):
any reason to not delete these? src/sentry_plugins/hipchat_ac/static/hipchat_ac/components/settings.jsx, line 65 [r3] (raw file):
i'd just do Comments from Reviewable |
@macqueen
This change is