Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send performance data with rediscluster #1564

Closed
sl0thentr0py opened this issue Aug 13, 2022 Discussed in #1563 · 4 comments
Closed

Cannot send performance data with rediscluster #1564

sl0thentr0py opened this issue Aug 13, 2022 Discussed in #1563 · 4 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@sl0thentr0py
Copy link
Member

Discussed in #1563

Originally posted by georgkrause August 13, 2022
Whenever the sentry sdk tries to send performance data, I get the following:

demo-api-1  |  [sentry] ERROR: Unexpected status code: 400 (body: b'{"spans":{"6":{"tags":{"redis.is_cluster":["Not a valid string."]}},"15":{"tags":{"redis.is_cluster":["Not a valid string."]}},"16":{"tags":{"redis.is_cluster":["Not a valid string."]}},"17":{"tags":{"redis.is_cluster":["Not a valid string."]}}}}')

Where can I start to find the cause for this? Any help is appreciated! :)

@sl0thentr0py sl0thentr0py self-assigned this Aug 13, 2022
@sl0thentr0py sl0thentr0py added Type: Bug Something isn't working Status: Backlog labels Aug 13, 2022
@bufke
Copy link

bufke commented Aug 14, 2022

A user reported this bug to GlitchTip which I believe is what's responsible for the 400 error attached. However it may be a bug in sentry-python. A Span interface tag field is documented as "A map or list of tags for this event. Each tag must be less than 200 characters." It's not exactly clear if this is intended to explicitly be a string. One could interpret "characters" as implying it needs to be a string, in which case sentry-python should probably convert it to a string. If it is intended to be a non-string or you feel the server should be responsible for coercing it as a string, then this issue should be closed.

Related issue

@sl0thentr0py
Copy link
Member Author

hmm ok I wasn't able to reproduce this. I tried the sample here and all kinds of tags - strings/ints/booleans go through so I'm not sure how to see your error. Please help with me reproduction steps so I can investigate further.

@sl0thentr0py
Copy link
Member Author

@bufke @georgkrause are you using self-hosted Sentry?

@sl0thentr0py
Copy link
Member Author

@bufke I just saw what GlitchTip is, our backends are supposed to be flexible in ingesting, so I believe you just need to fix the deserialization on your backend, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants