feat(profiling): Better gevent support #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
force-pushed
the
txiao/feat/better-gevent-profiling-support
branch
3 times, most recently
from
a9ffd5b
to
6c905d2
Compare
Base automatically changed from
txiao/ref/remove-sample-buffer-from-profiler
to
master
January 10, 2023 16:11
We're missing frames from gevent threads. Using `gevent.threadpool.ThreadPool` seems to fix that. The monkey patching gevent does is causing the sampler thread to run in a greenlet on the same thread as the all other greenlets. So when it is taking a sample, the sampler is current greenlet thus no useful stacks can be seen.
Zylphrex
force-pushed
the
txiao/feat/better-gevent-profiling-support
branch
from
6c905d2
to
0d5555c
Compare
|
One potential TODO for gevent would be to look into separating the samples by greenlet instead of thread id. Though this has the caveat that since all the greenlets are in the same thread, we're only able to capture a sample from the current greenlet each time. So if that is split across multiple samples, the final flamechart would appear as if we sample at a much lower frequency. |
sl0thentr0py
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We're missing frames from gevent threads. Using
gevent.threadpool.ThreadPoolseems to fix that. The monkey patching gevent does is causing the sampler thread
to run in a greenlet on the same thread as the all other greenlets. So when it
is taking a sample, the sampler is current greenlet thus no useful stacks can be
seen.