Fix middleware being patched multiple times when using FastAPI #1841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When the
StarletteIntegration
is used in a FastAPI app, as instructed in the docs, theAuthenticationMiddleware
andExceptionMiddleware
get patched every timeadd_middleware
oradd_exception_handler
is called, since these methods callbuild_middleware_stack
, where patchedMiddleware
instances are repatched without checking if they were already patched.If these functions are called enough times, Python registers this as infinite recursion (as we've discovered).
The changes look broad, but amount to the addition of two
if not_yet_patched
checks and indentation.